Test #1
Test #1
Conversation
src/features/voyage-planner.tsx
Outdated
| const [selectedPort, setSelectedPort] = useState(""); | ||
| const [addedPorts, setAddedPorts] = useState<Port[]>([]); | ||
| const [offset, setOffset] = useState(0); | ||
| const [fetchData, setFetchData] = useState([]); |
There was a problem hiding this comment.
This data is stored in the Redux store. Why are you duplicating it here?
There was a problem hiding this comment.
Thank you for your feedback John. I removed the duplicates from here. Please check the latest changes.
src/features/voyage-planner.tsx
Outdated
| } | ||
| function VoyagePlanner(params: VoyagePlannerParams) { | ||
| const [selectedPort, setSelectedPort] = useState(""); | ||
| const [addedPorts, setAddedPorts] = useState<Port[]>([]); |
There was a problem hiding this comment.
Added ports are in the redux store. Where are you duplicating here?
There was a problem hiding this comment.
I also removed here. Please check the latest changes.
src/features/voyage-planner.tsx
Outdated
| <h2>Voyage</h2> | ||
| {addedPorts && | ||
| addedPorts.map((item, key) => { | ||
| return <div key={key}>{item.name}</div>; |
There was a problem hiding this comment.
Low effort here. Remove port functionality? Re-arrange? No styling
There was a problem hiding this comment.
I removed this part as well.
src/features/voyage-planner.tsx
Outdated
| .getState() | ||
| .ports.ports.filter((item: Port) => item.name === selectedPort); | ||
| dispatch(addPorts(portTobeAdded[0])); | ||
| setAddedPorts(store.getState().voyage.ports); |
There was a problem hiding this comment.
Missed requirement to calculate estimated time of arrival, distance travelled.
There was a problem hiding this comment.
I also added the functionality for distance and estimated time of arrival here. Please check the latest code.
src/services/ports-reducer.ts
Outdated
| export function portsReducer(state = initialState, action: AnyAction): PortsState { | ||
| switch (action.type) { | ||
| case 'SETPORTACTION': | ||
| return { ...state, ports: action.portList } |
There was a problem hiding this comment.
You are doing a paginated fetch - the ports should be appended, not replaced
There was a problem hiding this comment.
Yes, I solved the issue here. Please check the latest changes which I made and let me know any further improvements
No description provided.